Add Reviews to Subjects #597
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PaoloCappelli
force-pushed
the
add-reviews-to-subjects
branch
5 times, most recently
from
7436f62
to
fdd05ad
Compare
PaoloCappelli
force-pushed
the
add-reviews-to-subjects
branch
2 times, most recently
from
dfc5c9b
to
d4cb4f7
Compare
PaoloCappelli
force-pushed
the
add-reviews-to-subjects
branch
from
d4cb4f7
to
c3adc20
Compare
| create_table :reviews do |t| | ||
| t.references :user, null: false, foreign_key: true | ||
| t.references :subject, null: false, foreign_key: true | ||
| t.integer :rating |
There was a problem hiding this comment.
should we make this not null?
Comment on lines
+5
to
+15
| def create | ||
| @review = current_user.reviews.create!(subject_id: params[:subject_id], rating: params[:rating]) | ||
|
|
||
| redirect_to subject_path(@review.subject) | ||
| end | ||
|
|
||
| def update | ||
| @review.update!(rating: params[:rating]) | ||
|
|
||
| redirect_to subject_path(@review.subject) | ||
| end |
There was a problem hiding this comment.
what do you think about combining these two actions and doing an "update or create"?
Comment on lines
+23
to
+30
| <%= link_to new_user_session_path do %> | ||
| <div class="login-container"> | ||
| Inicia sesión para calificar | ||
| <span class="material-symbols-outlined"> | ||
| login | ||
| </span> | ||
| </div> | ||
| <% end %> |
There was a problem hiding this comment.
what if we show the same stars, but when an unauthenticated user clicks them we redirect them to log in?
| @@ -0,0 +1,5 @@ | |||
| class AddAverageRatingToSubjects < ActiveRecord::Migration[7.1] | |||
| def change | |||
| add_column :subjects, :average_rating, :float | |||
There was a problem hiding this comment.
i'm ok with adding this, but i wonder if we should start with calculating it on the fly
| </div> | ||
| <% if current_user %> | ||
| <div class="rating-item"> | ||
| <% for value in 1..5 %> |
There was a problem hiding this comment.
Suggested change
| <% for value in 1..5 %> | |
| <% 1.upto(5).each |value| %> |
| <div class="rating-container"> | ||
| <div class="rating-item"> | ||
| <button class="material-icons mdc-icon-button">star</button> | ||
| <%= @subject.average_rating.present? ? @subject.average_rating : "Sin calificar" %> |
There was a problem hiding this comment.
Suggested change
| <%= @subject.average_rating.present? ? @subject.average_rating : "Sin calificar" %> | |
| <%= @subject.average_rating || "Sin calificar" %> |
| transition: transform 0.25s ease; | ||
|
|
||
| &:hover { | ||
| transform: scale(1.3); |
There was a problem hiding this comment.
is it easy/worth it highlighting all the stars to the left of the one that is on hover?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add the ability to submit 1-5 stars reviews to a
Subject.Summary
Reviewmodel that for eachUserandSubjectwill store aratingaverage_ratingcolumn toSubjectto store the average of all the reviews associated with itSubject'saverage_ratingevery time aReviewassociated with it changesReviewsControllerSubjectsview to show and submit reviews for a particular subjectGuidance 👀
Before adding any system specs to test the new UI. I would like to know your thoughts on the current approach, what's missing and what's not necessary
##Demo
Screen.Recording.2024-11-20.at.6.57.59.PM.mov